[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v2 17/19] target/arm: Move regime_using_lpae_format into inte
From: |
Fabiano Rosas |
Subject: |
[RFC PATCH v2 17/19] target/arm: Move regime_using_lpae_format into internal.h |
Date: |
Mon, 9 Jan 2023 19:42:30 -0300 |
This function is needed by common code (ptw.c), so move it along with
the other regime_* functions in internal.h. When we enable the build
without TCG, the tlb_helper.c file will not be present.
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
Richard: this cannot into ptw.c because that file is softmmu only
---
target/arm/internals.h | 21 ++++++++++++++++++---
target/arm/tcg/tlb_helper.c | 18 ------------------
2 files changed, 18 insertions(+), 21 deletions(-)
diff --git a/target/arm/internals.h b/target/arm/internals.h
index 865b9e8104..b1fccf13a3 100644
--- a/target/arm/internals.h
+++ b/target/arm/internals.h
@@ -614,9 +614,6 @@ ARMMMUIdx arm_v7m_mmu_idx_for_secstate_and_priv(CPUARMState
*env,
/* Return the MMU index for a v7M CPU in the specified security state */
ARMMMUIdx arm_v7m_mmu_idx_for_secstate(CPUARMState *env, bool secstate);
-/* Return true if the translation regime is using LPAE format page tables */
-bool regime_using_lpae_format(CPUARMState *env, ARMMMUIdx mmu_idx);
-
/*
* Return true if the stage 1 translation regime is using LPAE
* format page tables
@@ -781,6 +778,24 @@ static inline uint64_t regime_tcr(CPUARMState *env,
ARMMMUIdx mmu_idx)
return env->cp15.tcr_el[regime_el(env, mmu_idx)];
}
+/* Return true if the translation regime is using LPAE format page tables */
+static inline bool regime_using_lpae_format(CPUARMState *env, ARMMMUIdx
mmu_idx)
+{
+ int el = regime_el(env, mmu_idx);
+ if (el == 2 || arm_el_is_aa64(env, el)) {
+ return true;
+ }
+ if (arm_feature(env, ARM_FEATURE_PMSA) &&
+ arm_feature(env, ARM_FEATURE_V8)) {
+ return true;
+ }
+ if (arm_feature(env, ARM_FEATURE_LPAE)
+ && (regime_tcr(env, mmu_idx) & TTBCR_EAE)) {
+ return true;
+ }
+ return false;
+}
+
/**
* arm_num_brps: Return number of implemented breakpoints.
* Note that the ID register BRPS field is "number of bps - 1",
diff --git a/target/arm/tcg/tlb_helper.c b/target/arm/tcg/tlb_helper.c
index 60abcbebe6..31eb77f7df 100644
--- a/target/arm/tcg/tlb_helper.c
+++ b/target/arm/tcg/tlb_helper.c
@@ -12,24 +12,6 @@
#include "exec/helper-proto.h"
-/* Return true if the translation regime is using LPAE format page tables */
-bool regime_using_lpae_format(CPUARMState *env, ARMMMUIdx mmu_idx)
-{
- int el = regime_el(env, mmu_idx);
- if (el == 2 || arm_el_is_aa64(env, el)) {
- return true;
- }
- if (arm_feature(env, ARM_FEATURE_PMSA) &&
- arm_feature(env, ARM_FEATURE_V8)) {
- return true;
- }
- if (arm_feature(env, ARM_FEATURE_LPAE)
- && (regime_tcr(env, mmu_idx) & TTBCR_EAE)) {
- return true;
- }
- return false;
-}
-
/*
* Returns true if the stage 1 translation regime is using LPAE format page
* tables. Used when raising alignment exceptions, whose FSR changes depending
--
2.35.3
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, (continued)
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, Peter Maydell, 2023/01/10
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, Claudio Fontana, 2023/01/11
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, Thomas Huth, 2023/01/11
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, Fabiano Rosas, 2023/01/11
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, Richard Henderson, 2023/01/11
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, Fabiano Rosas, 2023/01/12
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, Peter Maydell, 2023/01/12
[RFC PATCH v2 14/19] tests: do not run qom-test on all machines for ARM KVM-only, Fabiano Rosas, 2023/01/09
[RFC PATCH v2 15/19] tests: device-introspect-test: cope with ARM TCG-only devices, Fabiano Rosas, 2023/01/09
[RFC PATCH v2 16/19] tests/tcg: Do not build/run TCG tests if TCG is disabled, Fabiano Rosas, 2023/01/09
[RFC PATCH v2 17/19] target/arm: Move regime_using_lpae_format into internal.h,
Fabiano Rosas <=
[RFC PATCH v2 18/19] cpu-defs.h: Expose CPUTLBEntryFull to non-TCG code, Fabiano Rosas, 2023/01/09
[RFC PATCH v2 19/19] target/arm: don't access TCG code when debugging with KVM, Fabiano Rosas, 2023/01/09