Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only

[Fabiano Rosas]

Peter Maydell <peter.maydell@linaro.org> writes:

> On Tue, 10 Jan 2023 at 13:00, Fabiano Rosas <farosas@suse.de> wrote:
>>
>> Thomas Huth <thuth@redhat.com> writes:
>>
>> > On 09/01/2023 23.42, Fabiano Rosas wrote:
>> >> From: Claudio Fontana <cfontana@suse.de>
>> >>
>> >> on ARM we currently list and build all machines, even when
>> >> building KVM-only, without TCG.
>> >>
>> >> Until we fix this (and we only list and build machines that are
>> >> compatible with KVM), only test specifically using the "virt"
>> >> machine in this case.
>> >
>> > Why don't you fix it immediately? ...
>>
>> My idea was to have in this series the minimum to unbreak the
>> --disable-tcg build and later bring the rest of the changes
>> incrementally.
>
> This test is basically checking "all the machines should
> work". That's an important invariant to maintain, so
> I don't think we should just skip it for Arm targets.

But what does "all machines" mean in a no-TCG build? The original intent
of the patch was that only 'virt' should be present and therefore the
only one tested.

>
> -- PMM