Re: [PATCH v6 28/33] hw/isa/piix3: Merge hw/isa/piix4.c

[Philippe Mathieu-Daudé]

On 12/1/23 13:50, Philippe Mathieu-Daudé wrote:
> On 9/1/23 18:23, Bernhard Beschow wrote:
> > Now that the PIIX3 and PIIX4 device models are sufficiently consolidated,
> > their implementations can be merged into one file for further
> > consolidation.
> >
> > Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> > Message-Id: <20221022150508.26830-37-shentey@gmail.com>
> > ---
> >   hw/isa/{piix3.c => piix.c} | 158 ++++++++++++++++++++
> >   hw/isa/piix4.c             | 285 -------------------------------------
> >   MAINTAINERS                |   6 +-
> >   hw/i386/Kconfig            |   2 +-
> >   hw/isa/Kconfig             |  12 +-
> >   hw/isa/meson.build         |   3 +-
> >   hw/mips/Kconfig            |   2 +-
> >   7 files changed, 165 insertions(+), 303 deletions(-)
> >   rename hw/isa/{piix3.c => piix.c} (75%)
> >   delete mode 100644 hw/isa/piix4.c
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

BTW I wonder why PIIX4 isn't calling pci_bus_set_route_irq_fn()...
Any clue?