qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v3 12/28] target/arm: Wrap arm_rebuild_hflags calls with


From: Richard Henderson
Subject: Re: [RFC PATCH v3 12/28] target/arm: Wrap arm_rebuild_hflags calls with tcg_enabled
Date: Fri, 13 Jan 2023 11:56:32 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 1/13/23 06:04, Fabiano Rosas wrote:
This is in preparation to moving the hflags code into its own file
under the tcg/ directory.

Signed-off-by: Fabiano Rosas<farosas@suse.de>
---
I extracted these into a separate patch so we can discuss. If I move
the tcg_enabled check to a header that would add overhead for all the
calls where we know for sure that the code is running with TCG. And I
don't think we want a new arm_rebuild_hflags_foo to be used for common
code.
---
  hw/arm/boot.c             |  6 +++++-
  hw/intc/armv7m_nvic.c     | 20 +++++++++++++-------
  target/arm/arm-powerctl.c |  7 +++++--
  target/arm/cpregs.c       |  2 +-
  target/arm/cpu.c          |  3 ++-
  target/arm/helper.c       | 16 ++++++++++++----
  target/arm/machine.c      |  5 ++++-
  7 files changed, 42 insertions(+), 17 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]