Re: [RFC PATCH] testing: probe gdb for supported architectures ahead of time

[Richard Henderson]

On 1/5/23 10:15, Alex Bennée wrote:
> Currently when we encounter a gdb that is old or not built with
> multiarch in mind we fail rather messily. Try and improve the
> situation by probing ahead of time and setting
> HOST_GDB_SUPPORTS_ARCH=y in the relevant tcg configs. We can then skip
> and give a more meaningful message if we don't run the test.
>
> [AJB: we still miss some arches, for example gdb uses s390 which fails
> when we look for s390x. Not sure what the best way to deal with that
> is? Maybe define a gdb_arch as we probe each target?]
>
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> Cc: Richard Henderson<richard.henderson@linaro.org>
> Cc: Paolo Bonzini<pbonzini@redhat.com>
> ---
>   configure                                     |  8 +++++
>   scripts/probe-gdb-support.sh                  | 36 +++++++++++++++++++
>   tests/tcg/aarch64/Makefile.target             |  2 +-
>   tests/tcg/multiarch/Makefile.target           |  5 +++
>   .../multiarch/system/Makefile.softmmu-target  |  6 +++-
>   tests/tcg/s390x/Makefile.target               |  2 +-
>   6 files changed, 56 insertions(+), 3 deletions(-)
>   create mode 100755 scripts/probe-gdb-support.sh

Plausible as a mechanism.

I would say that your script would need to actually examine all of the 'set architecture' 
output to map gdb arches to qemu arches.  In particular, the :foo stuff is important. 
E.g. mips:isa64 (amongst others) means mips64.

I can verify that I no longer get the MicroBlaze error with make check-tcg, so that part 
of the patch works.


r~