[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v4 07/15] tests/qtest: Adjust qom-test to always set a -c
From: |
Fabiano Rosas |
Subject: |
Re: [RFC PATCH v4 07/15] tests/qtest: Adjust qom-test to always set a -cpu option |
Date: |
Thu, 19 Jan 2023 16:12:22 -0300 |
Richard Henderson <richard.henderson@linaro.org> writes:
> On 1/19/23 03:54, Fabiano Rosas wrote:
>> Start using the qtest_get_machine_args function, which explicitly
>> sets the -cpu option according to the machine default.
>>
>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>> ---
>> tests/qtest/qom-test.c | 19 +++++++++++++++++--
>> 1 file changed, 17 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c
>> index d380261f8f..462e3c4281 100644
>> --- a/tests/qtest/qom-test.c
>> +++ b/tests/qtest/qom-test.c
>> @@ -78,14 +78,28 @@ static void test_properties(QTestState *qts, const char
>> *path, bool recurse)
>> qobject_unref(response);
>> }
>>
>> +static const char *arch_get_cpu(const char *machine)
>> +{
>> + const char *arch = qtest_get_arch();
>> +
>> + if (g_str_equal(arch, "aarch64")) {
>> + if (!strncmp(machine, "virt", 4)) {
>> + return "cortex-a57";
>
> I'm not keen on hard-coding cortex-a57 instead of max, even if they happen to
> evaluate to
> mostly the same thing currently for -accel qtest.
Ok.
> Nor am I keen on replicating this N times across N qtest files.
> Better perhaps in libqtest.c, or something?
> Or even directly in qtest_get_machine_args()?
Ah right, this was a callback in a previous version so there was no
"cpu" parameter to qtest_get_machine_args. Now I could indeed move
arch_get_cpu into libqtest.c somewhere.
- Re: [RFC PATCH v4 05/15] tests/qtest: Restrict tpm-tis-devices-{swtpm}-test to CONFIG_TCG, (continued)
- [RFC PATCH v4 07/15] tests/qtest: Adjust qom-test to always set a -cpu option, Fabiano Rosas, 2023/01/19
- [RFC PATCH v4 08/15] tests/qtest: Adjust test-hmp to always pass -cpu option, Fabiano Rosas, 2023/01/19
- [RFC PATCH v4 09/15] tests/qtest: Adjust device-introspect-test to always set a -cpu option, Fabiano Rosas, 2023/01/19
- [RFC PATCH v4 10/15] tests/qtest: aarch64: Set -cpu for numa-test, Fabiano Rosas, 2023/01/19
- [RFC PATCH v4 11/15] tests/qemu-iotests: Allow passing a -cpu option in the QEMU cmdline, Fabiano Rosas, 2023/01/19
- [RFC PATCH v4 12/15] tests/tcg: Do not build/run TCG tests if TCG is disabled, Fabiano Rosas, 2023/01/19