Re: [PATCH v2 09/11] tests/qtest/migration-test: Build command line using GString API (3/4)

[Richard Henderson]

On 1/19/23 04:58, Philippe Mathieu-Daudé wrote:
> Part 3/4: Convert accelerator options.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   tests/qtest/migration-test.c | 11 +++++------
>   1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index 8377b3976a..015b774a9e 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -603,6 +603,9 @@ static int test_migrate_start(QTestState **from, QTestState 
> **to,
>       got_stop = false;
>   
>       cmd_common = g_string_new("");
> +    g_string_append_printf(cmd_common, "-accel kvm%s ",
> +                           args->use_dirty_ring ? ",dirty-ring-size=4096" : 
> "");
> +    g_string_append(cmd_common, "-accel tcg ");

Maybe clearer as

  if (args->use_dirty_ring) {
      g_string_append(s, "-accel kvm,dirty-ring-size=4096 ");
  } else {
      g_string_append(s, "-accel kvm ");
  }

but what you have works, so,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~