[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 3/5] hw/nvram/eeprom_at24c: Add init_rom field and at24c_e
From: |
Peter Delevoryas |
Subject: |
Re: [PATCH v4 3/5] hw/nvram/eeprom_at24c: Add init_rom field and at24c_eeprom_init_rom helper |
Date: |
Wed, 25 Jan 2023 11:12:41 -0800 |
On Wed, Jan 25, 2023 at 04:53:20PM +0000, Ninad S Palsule wrote:
> Signed-off-by: Peter Delevoryas peter@pjd.dev<mailto:peter@pjd.dev>
> Reviewed-by: Joel Stanley joel@jms.id.au<mailto:joel@jms.id.au>
>
> Tested-by: Ninad Palsule
> ninadpalsule@us.ibm.com<mailto:ninadpalsule@us.ibm.com>
>
> Hi Peter,
> I applied your patches and made sure that different EEPROM images can be
> loaded from
> appropriate image files and it is working as expected.
Thanks Ninad, this is a good regression test to make sure I didn't break the
existing drive proprerty.
- Peter
>
> # Used following command to invoke the qemu.
> qemu-system-arm -M rainier-bmc -nographic \
> -kernel fitImage-linux.bin \
> -dtb aspeed-bmc-ibm-rainier.dtb \
> -initrd obmc-phosphor-initramfs.rootfs.cpio.xz \
> -drive file=obmc-phosphor-image.rootfs.wic.qcow2,if=sd,index=2 \
> -append "rootwait console=ttyS4,115200n8 root=PARTLABEL=rofs-a" \
> -device
> at24c-eeprom,bus=aspeed.i2c.bus.0,address=0x51,drive=a,rom-size=32768 -drive
> file=tpm.eeprom.bin,format=raw,if=none,id=a \
> -device
> at24c-eeprom,bus=aspeed.i2c.bus.7,address=0x50,drive=b,rom-size=65536 -drive
> file=oppanel.eeprom.bin,format=raw,if=none,id=b \
> -device
> at24c-eeprom,bus=aspeed.i2c.bus.7,address=0x51,drive=c,rom-size=65536 -drive
> file=lcd.eeprom.bin,format=raw,if=none,id=c \
> -device
> at24c-eeprom,bus=aspeed.i2c.bus.8,address=0x50,drive=d,rom-size=65536 -drive
> file=baseboard.eeprom.bin,format=raw,if=none,id=d \
> -device
> at24c-eeprom,bus=aspeed.i2c.bus.8,address=0x51,drive=e,rom-size=65536 -drive
> file=bmc.eeprom.bin,format=raw,if=none,id=e \
> -device
> at24c-eeprom,bus=aspeed.i2c.bus.9,address=0x50,drive=f,rom-size=131072 -drive
> file=vrm.eeprom.bin,format=raw,if=none,id=f \
> -device
> at24c-eeprom,bus=aspeed.i2c.bus.10,address=0x50,drive=g,rom-size=131072
> -drive file=vrm.eeprom.bin,format=raw,if=none,id=g \
> -device
> at24c-eeprom,bus=aspeed.i2c.bus.13,address=0x50,drive=h,rom-size=65536 -drive
> file=nvme.eeprom.bin,format=raw,if=none,id=h \
> -device
> at24c-eeprom,bus=aspeed.i2c.bus.14,address=0x50,drive=i,rom-size=65536 -drive
> file=nvme.eeprom.bin,format=raw,if=none,id=i \
> -device
> at24c-eeprom,bus=aspeed.i2c.bus.15,address=0x50,drive=j,rom-size=65536 -drive
> file=nvme.eeprom.bin,format=raw,if=none,id=j
Re: [PATCH v4 3/5] hw/nvram/eeprom_at24c: Add init_rom field and at24c_eeprom_init_rom helper, Corey Minyard, 2023/01/25
[PATCH v4 5/5] hw/nvram/eeprom_at24c: Make reset behavior more like hardware, Peter Delevoryas, 2023/01/17