[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/14] hw/core: Introduce TYPE_SHARED_IRQ
From: |
David Woodhouse |
Subject: |
Re: [PATCH 04/14] hw/core: Introduce TYPE_SHARED_IRQ |
Date: |
Thu, 09 Jan 2025 11:43:56 +0000 |
User-agent: |
Evolution 3.52.3-0ubuntu1 |
On Wed, 2025-01-08 at 14:26 +0000, Bernhard Beschow wrote:
>
>
> Am 8. Januar 2025 09:25:28 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
> > Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> > ---
> > include/hw/core/shared-irq.h | 39 ++++++++++++++++
> > hw/core/shared-irq.c | 88 ++++++++++++++++++++++++++++++++++++
> > hw/core/Kconfig | 3 ++
> > hw/core/meson.build | 1 +
> > 4 files changed, 131 insertions(+)
> > create mode 100644 include/hw/core/shared-irq.h
> > create mode 100644 hw/core/shared-irq.c
> >
> > diff --git a/include/hw/core/shared-irq.h b/include/hw/core/shared-irq.h
> > new file mode 100644
>
> As pointed out by David, this device is redundant to TYPE_OR_IRQ. I'll drop
> it in v2.
Of course, I'd much rather *fix* it to do a reverse callback up the
chain when the line is deasserted, to check whether any sources want it
to be asserted again. That's the only way we can do VFIO level
interrupts properly.
smime.p7s
Description: S/MIME cryptographic signature
- [PATCH 08/14] hw/sd/sd: Allow for inverting polarities of presence and write-protect GPIOs, (continued)
[PATCH 04/14] hw/core: Introduce TYPE_SHARED_IRQ, Bernhard Beschow, 2025/01/08
[PATCH 10/14] hw/timer/imx_gpt: Remove unused define, Bernhard Beschow, 2025/01/08
[PATCH 07/14] hw/sd/sd: Remove legacy sd_set_cb() in favor of GPIOs, Bernhard Beschow, 2025/01/08
[PATCH 12/14] hw/i2c/imx_i2c: Convert DPRINTF() to trace events, Bernhard Beschow, 2025/01/08
[PATCH 06/14] hw/gpio/imx_gpio: Don't clear input GPIO values upon reset, Bernhard Beschow, 2025/01/08