[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-block] [PULL 62/73] virtio-blk: Remove the stale FIXME comment

From: Kevin Wolf
Subject: [Qemu-block] [PULL 62/73] virtio-blk: Remove the stale FIXME comment
Date: Mon, 9 Mar 2015 16:41:47 +0100

From: Fam Zheng <address@hidden>

By default, we have ioeventfd enabled, so the IO request processing is
in IO thread; in the vcpu thread, guest mode is returned to as quickly
as possible, and completion is delivered via irqfd. Therefore this
comment from the initial implementation is barely relevant.

Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
 hw/block/virtio-blk.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 7b0b653..24ada67 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -597,12 +597,6 @@ static void virtio_blk_handle_output(VirtIODevice *vdev, 
VirtQueue *vq)
     if (mrb.num_reqs) {
         virtio_blk_submit_multireq(s->blk, &mrb);
-    /*
-     * FIXME: Want to check for completions before returning to guest mode,
-     * so cached reads and writes are reported as quickly as possible. But
-     * that should be done in the generic block layer.
-     */
 static void virtio_blk_dma_restart_bh(void *opaque)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]