[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 02/17] qapi: Add optional field "name" to blo
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH v2 02/17] qapi: Add optional field "name" to block dirty bitmap |
Date: |
Wed, 11 Mar 2015 15:34:18 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Mar 02, 2015 at 06:19:48PM -0500, John Snow wrote:
> From: Fam Zheng <address@hidden>
>
> This field will be set for user created dirty bitmap. Also pass in an
> error pointer to bdrv_create_dirty_bitmap, so when a name is already
> taken on this BDS, it can report an error message. This is not global
> check, two BDSes can have dirty bitmap with a common name.
>
> Implemented bdrv_find_dirty_bitmap to find a dirty bitmap by name, will
> be used later when other QMP commands want to reference dirty bitmap by
> name.
>
> Add bdrv_dirty_bitmap_make_anon. This unsets the name of dirty bitmap.
>
> Signed-off-by: Fam Zheng <address@hidden>
> Signed-off-by: John Snow <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> block.c | 32 +++++++++++++++++++++++++++++++-
> block/mirror.c | 2 +-
> include/block/block.h | 7 ++++++-
> migration/block.c | 2 +-
> qapi/block-core.json | 4 +++-
> 5 files changed, 42 insertions(+), 5 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgpSpHXADSY_h.pgp
Description: PGP signature
- Re: [Qemu-block] [PATCH v2 03/17] qmp: Ensure consistent granularity type, (continued)
- [Qemu-block] [PATCH v2 06/17] hbitmap: add hbitmap_merge, John Snow, 2015/03/02
- [Qemu-block] [PATCH v2 04/17] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove, John Snow, 2015/03/02
- [Qemu-block] [PATCH v2 01/17] docs: incremental backup documentation, John Snow, 2015/03/02
- [Qemu-block] [PATCH v2 02/17] qapi: Add optional field "name" to block dirty bitmap, John Snow, 2015/03/02
- Re: [Qemu-block] [PATCH v2 02/17] qapi: Add optional field "name" to block dirty bitmap,
Stefan Hajnoczi <=
- [Qemu-block] [PATCH v2 07/17] block: Add bitmap disabled status, John Snow, 2015/03/02
- [Qemu-block] [PATCH v2 05/17] block: Introduce bdrv_dirty_bitmap_granularity(), John Snow, 2015/03/02
- [Qemu-block] [PATCH v2 08/17] block: Add bitmap successors, John Snow, 2015/03/02
- [Qemu-block] [PATCH v2 14/17] block: Resize bitmaps on bdrv_truncate, John Snow, 2015/03/02