[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH for-2.3] raw-posix: Deprecate aio=threads fallba

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH for-2.3] raw-posix: Deprecate aio=threads fallback without O_DIRECT
Date: Tue, 17 Mar 2015 08:22:24 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 03/17/2015 06:48 AM, Kevin Wolf wrote:
> Currently, if the user requests aio=native, but forgets to choose a
> cache mode that sets O_DIRECT, that request is silently ignored and raw
> falls back to aio=threads.
> Deprecate that behaviour so we can make it an error in future qemu
> versions.
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/raw-posix.c | 8 ++++++++
>  1 file changed, 8 insertions(+)

Silent behavior changes are always mean, so making this noisy for now
with the intent of an error in the future is good.

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]