[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 03/11] block: add transactional callbacks featur

From: John Snow
Subject: Re: [Qemu-block] [PATCH 03/11] block: add transactional callbacks feature
Date: Tue, 17 Mar 2015 14:23:16 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 03/17/2015 02:18 PM, Eric Blake wrote:
On 03/17/2015 12:04 PM, John Snow wrote:

+typedef void (CallbackFn)(void *opaque, int ret);
+/* Temporary. Removed in the next patch. */

Actually, no. :-)

(remove in patch 7)

Why are you making them non-static in the first place? I see both
functions mentioned in patch 3 and patch 7 only (except for context in
patch 6).

Won't compile otherwise, because they have no users as of this patch. I
am trying to keep the size of these patches down and in a sane order.

Another solution is to mark it static, but also add
__attribute__((unused)) to shut the compiler up, so that you don't cause
build failures, but also don't cause reviewers to wonder who is using
it.  Then when it finally gets used, a patch to remove the attribute is
easier to see than a patch adding static.

Good trick, thanks.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]