[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH] block: Fix blockdev-backup not to

From: Markus Armbruster
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH] block: Fix blockdev-backup not to use funky error class
Date: Thu, 19 Mar 2015 12:51:53 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Kevin Wolf <address@hidden> writes:

> Am 17.03.2015 um 08:36 hat Markus Armbruster geschrieben:
>> Error classes are a leftover from the days of "rich" error objects.
>> New code should always use ERROR_CLASS_GENERIC_ERROR.  Commit
>> b7b9d39..7c6a4ab added uses of ERROR_CLASS_DEVICE_NOT_FOUND.  Replace
>> them.
>> Signed-off-by: Markus Armbruster <address@hidden>
> Thanks, applied to the block branch.
> Eric, please speak up if libvirt needs the error code for any of these.

I grepped through the libvirt source code (should've mentioned that),
but review from an expert is of course always welcome!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]