[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [RFC PATCH COLO v2 08/13] Allow creating backup jobs wh
From: |
Wen Congyang |
Subject: |
Re: [Qemu-block] [RFC PATCH COLO v2 08/13] Allow creating backup jobs when opening BDS |
Date: |
Thu, 26 Mar 2015 15:23:54 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 03/26/2015 03:18 PM, Fam Zheng wrote:
> On Thu, 03/26 15:14, Wen Congyang wrote:
>> On 03/26/2015 03:07 PM, Fam Zheng wrote:
>>> On Wed, 03/25 17:36, Wen Congyang wrote:
>>>> When opening BDS, we need to create backup jobs for
>>>> image-fleecing.
>>>
>>> How does this commit message relate to the Makefile change?
>>
>> Hmm, we need to use backup API in block.c, and block.o will
>> be used by qemu-img which doesn't use common-obj.
>
> I see. How about adding the referenced functions to stubs/?
Good idea. I will try it.
Thanks
Wen Congyang
>
> Fam
>
>>
>> Thanks
>> Wen Congyang
>>
>>>
>>>>
>>>> Signed-off-by: Wen Congyang <address@hidden>
>>>> Signed-off-by: zhanghailiang <address@hidden>
>>>> Signed-off-by: Gonglei <address@hidden>
>>>> Cc: Jeff Cody <address@hidden>
>>>> ---
>>>> block/Makefile.objs | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/block/Makefile.objs b/block/Makefile.objs
>>>> index db2933e..0950973 100644
>>>> --- a/block/Makefile.objs
>>>> +++ b/block/Makefile.objs
>>>> @@ -21,10 +21,10 @@ block-obj-$(CONFIG_ARCHIPELAGO) += archipelago.o
>>>> block-obj-$(CONFIG_LIBSSH2) += ssh.o
>>>> block-obj-y += accounting.o
>>>> block-obj-y += write-threshold.o
>>>> +block-obj-y += backup.o
>>>>
>>>> common-obj-y += stream.o
>>>> common-obj-y += commit.o
>>>> -common-obj-y += backup.o
>>>>
>>>> iscsi.o-cflags := $(LIBISCSI_CFLAGS)
>>>> iscsi.o-libs := $(LIBISCSI_LIBS)
>>>> --
>>>> 2.1.0
>>>>
>>> .
>>>
>>
> .
>
- Re: [Qemu-block] [RFC PATCH COLO v2 04/13] Add new block driver interfaces to control block replication, (continued)
[Qemu-block] [RFC PATCH COLO v2 10/13] Backup: clear all bitmap when doing block checkpoint, Wen Congyang, 2015/03/25
[Qemu-block] [RFC PATCH COLO v2 07/13] allow writing to the backing file, Wen Congyang, 2015/03/25
[Qemu-block] [RFC PATCH COLO v2 09/13] block: Parse "backing_reference" option to reference existing BDS, Wen Congyang, 2015/03/25
[Qemu-block] [RFC PATCH COLO v2 12/13] skip nbd_target when starting block replication, Wen Congyang, 2015/03/25