[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 1/5] block: Use bdrv_is_sg() everywhere
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v2 1/5] block: Use bdrv_is_sg() everywhere |
Date: |
Mon, 11 May 2015 12:04:52 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 08.05.2015 um 19:47 hat Dimitris Aragiorgis geschrieben:
> Instead of checking bs->sg use bdrv_is_sg() consistently throughout
> the code.
>
> Signed-off-by: Dimitris Aragiorgis <address@hidden>
> Reviewed-by: Paolo Bonzini <address@hidden>
> ---
> block.c | 6 +++---
> block/iscsi.c | 2 +-
> block/raw-posix.c | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index 24d8582..24b061f 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -302,9 +302,9 @@ static void raw_probe_alignment(BlockDriverState *bs, int
> fd, Error **errp)
> BDRVRawState *s = bs->opaque;
> char *buf;
>
> - /* For /dev/sg devices the alignment is not really used.
> + /* For SG devices the alignment is not really used.
> With buffered I/O, we don't have any restrictions. */
If you want to change this comment, why not "SCSI generic" instead of
letting people guess what sg might mean in this context?
Kevin
- [Qemu-block] [PATCH v2 2/5] Fix migration in case of scsi-generic, (continued)
- [Qemu-block] [PATCH v2 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT, Dimitris Aragiorgis, 2015/05/08
- [Qemu-block] [PATCH v2 1/5] block: Use bdrv_is_sg() everywhere, Dimitris Aragiorgis, 2015/05/08
- Re: [Qemu-block] [PATCH v2 1/5] block: Use bdrv_is_sg() everywhere,
Kevin Wolf <=
- [Qemu-block] [PATCH v2 5/5] raw-posix: Introduce hdev_is_sg(), Dimitris Aragiorgis, 2015/05/08
- [Qemu-block] [PATCH v2 4/5] raw-posix: Use DPRINTF for DEBUG_FLOPPY, Dimitris Aragiorgis, 2015/05/08
- Re: [Qemu-block] [PATCH v2 0/5] Some fixes related to scsi-generic, Paolo Bonzini, 2015/05/10