[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 05/11] virtio-blk: Don't handle output when t
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [PATCH v2 05/11] virtio-blk: Don't handle output when there is "device IO" op blocker |
Date: |
Wed, 13 May 2015 19:09:14 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, 05/13 12:26, Paolo Bonzini wrote:
>
>
> On 13/05/2015 19:28, Fam Zheng wrote:
> > +static void virtio_blk_data_plane_pause(VirtIOBlock *vblk)
> > +{
> > + VirtIOBlockDataPlane *s = vblk->dataplane;
> > +
> > + event_notifier_test_and_clear(&s->host_notifier);
> > + aio_set_event_notifier(s->ctx, &s->host_notifier, NULL);
> > +}
> > +
> > +static void handle_notify(EventNotifier *e);
> > +static void virtio_blk_data_plane_resume(VirtIOBlock *vblk)
> > +{
> > + VirtIOBlockDataPlane *s = vblk->dataplane;
> > +
> > + aio_set_event_notifier(s->ctx, &s->host_notifier, handle_notify);
> > +
> > + event_notifier_set(&s->host_notifier);
> > +}
>
> Perhaps add a note that these are called under aio_context_acquire?
>
OK, good idea.
Fam
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 01/11] block: Add op blocker type "device IO", (continued)
[Qemu-block] [PATCH v2 03/11] block-backend: Add blk_op_blocker_add_notifier, Fam Zheng, 2015/05/13
[Qemu-block] [PATCH v2 02/11] block: Add op blocker notifier list, Fam Zheng, 2015/05/13
[Qemu-block] [PATCH v2 04/11] virtio-blk: Move complete_request to 'ops' structure, Fam Zheng, 2015/05/13
[Qemu-block] [PATCH v2 05/11] virtio-blk: Don't handle output when there is "device IO" op blocker, Fam Zheng, 2015/05/13
[Qemu-block] [PATCH v2 07/11] blockdev: Block device IO during internal snapshot transaction, Fam Zheng, 2015/05/13
[Qemu-block] [PATCH v2 06/11] nbd-server: Clear "can_read" when "device io" blocker is set, Fam Zheng, 2015/05/13
[Qemu-block] [PATCH v2 08/11] blockdev: Block device IO during external snapshot transaction, Fam Zheng, 2015/05/13
[Qemu-block] [PATCH v2 09/11] blockdev: Block device IO during drive-backup transaction, Fam Zheng, 2015/05/13
[Qemu-block] [PATCH v2 10/11] blockdev: Block device IO during blockdev-backup transaction, Fam Zheng, 2015/05/13
Re: [Qemu-block] [PATCH v2 10/11] blockdev: Block device IO during blockdev-backup transaction, Paolo Bonzini, 2015/05/13