[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] blockdev: no need to drain+flush i
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] blockdev: no need to drain+flush in hmp_drive_del |
Date: |
Thu, 28 May 2015 21:45:29 -0400 (EDT) |
----- Original Message -----
> bdrv_close already does that, and in fact hmp_drive_del would need
> another drain after the flush (which bdrv_close does). So remove
> the duplication.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
> ---
> blockdev.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index 5eaf77e..d506a70 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -2143,9 +2143,6 @@ int hmp_drive_del(Monitor *mon, const QDict *qdict,
> QObject **ret_data)
> return -1;
> }
>
> - /* quiesce block driver; prevent further io */
> - bdrv_drain_all();
> - bdrv_flush(bs);
> bdrv_close(bs);
>
> /* if we have a device attached to this BlockDriverState
> --
> 2.4.1
>
>
>