[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v7 2/8] qmp: Add optional bool "unmap" to drive-
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [PATCH v7 2/8] qmp: Add optional bool "unmap" to drive-mirror |
|
Date: |
Mon, 08 Jun 2015 16:54:49 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 08/06/2015 16:51, Eric Blake wrote:
>> > +# @unmap: #optional Whether to try to unmap target sectors where source
>> > has
>> > +# only zero. If true, and target unallocated sectors will read as
>> > zero,
>> > +# target image sectors will be unmapped; otherwise, zeroes will be
>> > +# written. Both will result in identical contents.
>> > +# Default is true. (Since 2.4)
>> > #
> Per the other thread on adding 'detect-zeroes', should we instead be
> using an enum here that describes one of several behaviors without an
> explosion into multiple knobs?
See my answer there. :)
Paolo
- [Qemu-block] [PATCH v7 0/8] block: Mirror discarded sectors, Fam Zheng, 2015/06/08
- [Qemu-block] [PATCH v7 1/8] block: Add bdrv_get_block_status_above, Fam Zheng, 2015/06/08
- [Qemu-block] [PATCH v7 2/8] qmp: Add optional bool "unmap" to drive-mirror, Fam Zheng, 2015/06/08
- [Qemu-block] [PATCH v7 3/8] mirror: Do zero write on target if sectors not allocated, Fam Zheng, 2015/06/08
- [Qemu-block] [PATCH v7 4/8] block: Fix dirty bitmap in bdrv_co_discard, Fam Zheng, 2015/06/08
- [Qemu-block] [PATCH v7 5/8] block: Remove bdrv_reset_dirty, Fam Zheng, 2015/06/08
- [Qemu-block] [PATCH v7 6/8] qemu-iotests: Make block job methods common, Fam Zheng, 2015/06/08
- [Qemu-block] [PATCH v7 7/8] qemu-iotests: Add test case for mirror with unmap, Fam Zheng, 2015/06/08
- [Qemu-block] [PATCH v7 8/8] iotests: Use event_wait in wait_ready, Fam Zheng, 2015/06/08
- Re: [Qemu-block] [PATCH v7 0/8] block: Mirror discarded sectors, Stefan Hajnoczi, 2015/06/08