[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floo
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-block] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor() |
|
Date: |
Fri, 24 Jul 2015 09:39:58 +0100 |
On 24 July 2015 at 06:10, Paolo Bonzini <address@hidden> wrote:
>
>
> On 23/07/2015 22:10, Peter Maydell wrote:
>>> > The series looks good, but I'd prefer (especially for patch 4 which is
>>> > in a fast path) if pow2ceil and pow2floor were made inline.
>> Yeah, I was wondering if I was going to be asked to do that.
>> Note that qemu_fls() is/was *not* inline, though, so you're
>> taking an out-of-line function call on these code paths
>> already.
>
> But in patch 4 the call is only in the rare case where "l & (l - 1)" is
> not zero.
True. Any preferences for which header file to put them in?
qemu-common.h is where the prototype is currently and where
the inline is_power_of_2() is defined...
thanks
-- PMM
- [Qemu-block] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor(), Peter Maydell, 2015/07/23
- [Qemu-block] [PATCH 3/5] hw/block/nvme.c: Use pow2ceil() rather than hand-calculation, Peter Maydell, 2015/07/23
- Re: [Qemu-block] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor(), Paolo Bonzini, 2015/07/23
- [Qemu-block] [PATCH 4/5] exec.c: Use pow2floor() rather than hand-calculation, Peter Maydell, 2015/07/23
- [Qemu-block] [PATCH 5/5] Remove unused qemu_fls function, Peter Maydell, 2015/07/23
- [Qemu-block] [PATCH 2/5] hw/virtio/virtio-pci: Use pow2ceil() rather than hand-calculation, Peter Maydell, 2015/07/23
- [Qemu-block] [PATCH 1/5] hw/pci: Use pow2ceil() rather than hand-calculation, Peter Maydell, 2015/07/23
- Re: [Qemu-block] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor(), Paolo Bonzini, 2015/07/23