[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 03/11] block: Mark fd handlers as "protocol"
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [PATCH v2 03/11] block: Mark fd handlers as "protocol" |
Date: |
Mon, 7 Sep 2015 12:43:32 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, 08/27 14:53, Stefan Hajnoczi wrote:
> On Wed, Jul 29, 2015 at 12:42:06PM +0800, Fam Zheng wrote:
> > diff --git a/include/block/aio.h b/include/block/aio.h
> > index bd1d44b..d02ddfa 100644
> > --- a/include/block/aio.h
> > +++ b/include/block/aio.h
> > @@ -273,6 +273,7 @@ bool aio_pending(AioContext *ctx);
> > bool aio_dispatch(AioContext *ctx);
> >
> > #define AIO_CLIENT_UNSPECIFIED (1 << 0)
> > +#define AIO_CLIENT_PROTOCOL (1 << 1)
>
> The semantics need to be documented here, not just in the commit
> description.
>
> AIO_CLIENT_BLOCK_DRIVER or AIO_CLIENT_BLOCK_PROTOCOL seems like a
> clearer name to me since "protocol" just by itself could mean many
> things.
OK, renaming to AIO_CLIENT_BLOCK_DRIVER.
Thanks,
Fam
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-block] [PATCH v2 03/11] block: Mark fd handlers as "protocol",
Fam Zheng <=