[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 2/4] block: Add 'ignore-backing' field to Blo
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [PATCH v3 2/4] block: Add 'ignore-backing' field to BlockdevOptionsGenericCOWFormat |
Date: |
Mon, 14 Sep 2015 07:54:02 +0200 |
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Fri 11 Sep 2015 07:33:41 PM CEST, Max Reitz <address@hidden> wrote:
>>> So why do we need the new flag? Because "backing: ''" is ugly?
>>
>> I guess it's just because you're the only one who actually reads the
>> documentation. When discussing this, I didn't remember that we
>> already had a way to express this (an additional bool wouldn't have
>> been my favourite solution anyway). Thanks for catching this.
>
> I read the patch, it was part of the context. ;-)
Oh, that was embarrassing :-) Yes, it was the discussion from two weeks
ago about passing empty strings as BlockdevRef that made me think that
this would be ugly.
Anyway, was this ever implemented? It seems that passing a string to the
'backing' parameter is only specified in the JSON schema, but no one
actually uses that.
So I'll implement that for the next version of my series.
Berto
- [Qemu-block] [PATCH v3 3/4] block: add a 'blockdev-snapshot' QMP command, (continued)
Re: [Qemu-block] [PATCH v3 2/4] block: Add 'ignore-backing' field to BlockdevOptionsGenericCOWFormat, Eric Blake, 2015/09/11