[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/3] block: prohibit migration during BlockJobs
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [PATCH 1/3] block: prohibit migration during BlockJobs |
|
Date: |
Thu, 1 Oct 2015 20:03:58 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 01/10/2015 18:34, John Snow wrote:
> Unless we can prove this to be safe for specific cases,
> the default should be to prohibit migration during BlockJobs.
Block jobs do not affect the current block, only other block device,
hence they *are* safe for migration.
What you want, I think, is the target not to be garbage when migration
ends. Based on this you can block specific cases, namely mirror which
you already do allow (patch 2) and backup except for sync='none'.
Paolo
> In conjunction with
> "migration: disallow_migrate_add_blocker during migration",
> this should be sufficient to disallow the blockjob from starting
> in the event of an in-progress migration.