[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v7 01/10] aio: Add "is_external" flag for event
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH v7 01/10] aio: Add "is_external" flag for event handlers |
Date: |
Fri, 23 Oct 2015 15:58:52 +0100 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Oct 23, 2015 at 11:08:05AM +0800, Fam Zheng wrote:
> All callers pass in false, and the real external ones will switch to
> true in coming patches.
>
> Signed-off-by: Fam Zheng <address@hidden>
> Reviewed-by: Jeff Cody <address@hidden>
> Reviewed-by: Kevin Wolf <address@hidden>
> ---
> aio-posix.c | 6 ++++-
> aio-win32.c | 5 ++++
> async.c | 3 ++-
> block/curl.c | 14 +++++-----
> block/iscsi.c | 9 +++----
> block/linux-aio.c | 5 ++--
> block/nbd-client.c | 10 ++++---
> block/nfs.c | 17 +++++-------
> block/sheepdog.c | 38 ++++++++++++++++++---------
> block/ssh.c | 5 ++--
> block/win32-aio.c | 5 ++--
> hw/block/dataplane/virtio-blk.c | 6 +++--
> hw/scsi/virtio-scsi-dataplane.c | 24 +++++++++++------
> include/block/aio.h | 2 ++
> iohandler.c | 3 ++-
> nbd.c | 4 ++-
> tests/test-aio.c | 58
> +++++++++++++++++++++++------------------
> 17 files changed, 130 insertions(+), 84 deletions(-)
>
> diff --git a/aio-posix.c b/aio-posix.c
> index d477033..f0f9122 100644
> --- a/aio-posix.c
> +++ b/aio-posix.c
> @@ -25,6 +25,7 @@ struct AioHandler
> IOHandler *io_write;
> int deleted;
> void *opaque;
> + bool is_external;
Please explain why is_external is needed so this patch makes sense by
itself.
A doc comment explaining the semantics of this new flag would be best.
That way people modifying the code will know how to use it correctly.
- [Qemu-block] [PATCH v7 00/10] block: Protect nested event loop with bdrv_drained_begin and bdrv_drained_end, Fam Zheng, 2015/10/22
- [Qemu-block] [PATCH v7 01/10] aio: Add "is_external" flag for event handlers, Fam Zheng, 2015/10/22
- Re: [Qemu-block] [PATCH v7 01/10] aio: Add "is_external" flag for event handlers,
Stefan Hajnoczi <=
- [Qemu-block] [PATCH v7 02/10] nbd: Mark fd handlers client type as "external", Fam Zheng, 2015/10/22
- [Qemu-block] [PATCH v7 03/10] dataplane: Mark host notifiers' client type as "external", Fam Zheng, 2015/10/22
- [Qemu-block] [PATCH v7 04/10] aio: introduce aio_{disable, enable}_external, Fam Zheng, 2015/10/22
- [Qemu-block] [PATCH v7 05/10] block: Introduce "drained begin/end" API, Fam Zheng, 2015/10/22
- [Qemu-block] [PATCH v7 06/10] block: Add "drained begin/end" for transactional external snapshot, Fam Zheng, 2015/10/22
- [Qemu-block] [PATCH v7 07/10] block: Add "drained begin/end" for transactional backup, Fam Zheng, 2015/10/22