[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v10 00/14] block: incremental backup transaction

From: Stefan Hajnoczi
Subject: Re: [Qemu-block] [PATCH v10 00/14] block: incremental backup transactions using BlockJobTxn
Date: Tue, 3 Nov 2015 15:22:08 +0000
User-agent: Mutt/1.5.24 (2015-08-30)

On Fri, Oct 23, 2015 at 07:56:38PM -0400, John Snow wrote:
> Welcome to V10!
> Where'd 8 and 9 go? Private off-list missives from Fam.
> Now you, I, and everyone on qemu-devel are staring at V10.
> What's new in V10?
> I replaced the per-action "transactional-cancel" parameter with
> a per-transaction paremeter named "err-cancel" which is implemented
> as an enum in case we want to add new behaviors in the future, such
> as a "jobs only" cancel mode.
> For now, it's "all" or "none", and if you use it with actions that
> do not support the latent transactional cancel, you will receive
> an error for your troubles.

I left comments on a few patches.

The "err-cancel" and "ActionCancelMode" naming does not describe the
concept fully, since successful block jobs will also behave differently
(waiting for each other to finish before fully completing).
"blockjob-transactions" is the best name I can think of that describes
the full concept rather than focus on just cancellation.

Besides that I'm happy with the QMP interface.

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]