[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v7 11/35] util: introduce qemu_file_getlength()

From: Xiao Guangrong
Subject: Re: [Qemu-block] [PATCH v7 11/35] util: introduce qemu_file_getlength()
Date: Mon, 9 Nov 2015 12:44:55 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 11/06/2015 11:50 PM, Eduardo Habkost wrote:
As this patch affects raw_getlength(), CCing the raw block driver
maintainer and the qemu-block mailing list.

Eduardo, thanks for your reminder. I will keep CCing Kevin and qemu-block mail
list for future version.

On Mon, Nov 02, 2015 at 05:13:13PM +0800, Xiao Guangrong wrote:
It is used to get the size of the specified file, also qemu_fd_getlength()
is introduced to unify the code with raw_getlength() in block/raw-posix.c

Signed-off-by: Xiao Guangrong <address@hidden>
  block/raw-posix.c    |  7 +------
  include/qemu/osdep.h |  2 ++
  util/osdep.c         | 31 +++++++++++++++++++++++++++++++

I know I was the one who suggested osdep.c, but maybe oslib-posix.c is a
more appropriate place for the new function?

Since the function we introduced here can work on both windows and posix, so
i thing osdep.c is the right place. Otherwise we should implement it for 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]