[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v7 02/24] blockjob: Call bdrv_unref() on creatio

From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH v7 02/24] blockjob: Call bdrv_unref() on creation error
Date: Wed, 18 Nov 2015 16:24:29 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Am 09.11.2015 um 23:39 hat Max Reitz geschrieben:
> If block_job_create() fails, it should release its reference to the
> job's BDS. Normally, this is done in the callback provided by the
> caller, but that callback will not be invoked if the block job failed to
> be created.
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Alberto Garcia <address@hidden>
> Reviewed-by: Kevin Wolf <address@hidden>

Commit 18930ba3 already fixed this. Now adding another bdrv_unref()
would be wrong, so I guess we have to simply drop the patch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]