[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH for 2.6 0/3] Bitmap clean-up patches for 2.6

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [Qemu-block] [PATCH for 2.6 0/3] Bitmap clean-up patches for 2.6
Date: Fri, 20 Nov 2015 19:42:20 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0

Hi Fam!

Thanks for it, I really like the idea about dropping granularity from hbitmap. I've waste lots of time understanding the code about bitmaps. Keeping in mind what units are in what granularity and what granularity is in what units is more than inconvenient)

On 20.11.2015 12:59, Fam Zheng wrote:
This makes a cleaner base for more dirty bitmap work. "granularity" appearing
with different representations have always been mind twisting, remove it from
HBitmap to make the interface and implementation simpler. Upon this, it is
a bit easier to add persistent dirty bitmap functionalities.

Block dirty bitmap is not unit-tested, so the removal of HBitmap test code
looks like a loss, but the overall test coverage is barely affected as we also
have various mirror, commit and backup iotest cases, and they do catch various
bugs when I wrote the patches.

Please review!


Fam Zheng (3):
   backup: Use Bitmap to replace "s->bitmap"
   block: Hide HBitmap in block dirty bitmap interface
   hbitmap: Drop "granularity"

  block.c                |  79 ++++++++++++++-----
  block/backup.c         |  25 +++---
  block/mirror.c         |  14 ++--
  include/block/block.h  |   9 ++-
  include/qemu/hbitmap.h |  20 +----
  tests/test-hbitmap.c   | 206 ++++++++-----------------------------------------
  util/hbitmap.c         |  64 +++------------
  7 files changed, 135 insertions(+), 282 deletions(-)

Best regards,
* now, @virtuozzo.com instead of @parallels.com. Sorry for this inconvenience.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]