[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 17/21] block: Move cache options into options
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v3 17/21] block: Move cache options into options QDict |
Date: |
Fri, 4 Dec 2015 23:07:03 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 04.12.2015 14:35, Kevin Wolf wrote:
> This adds the cache mode options to the QDict, so that they can be
> specified for child nodes (e.g. backing.cache.direct=off).
>
> The cache modes are not removed from the flags at this point; instead,
> options and flags are kept in sync. If the user specifies both flags and
> options, the options take precedence.
>
> Child node inherit cache modes as options now, they don't use flags any
> more.
>
> Note that this forbids specifying the cache mode for empty drives. It
> didn't make sense anyway to specify it there, because it didn't have any
> effect. blockdev_init() considers the cache options now bdrv_open()
> options and therefore doesn't create an empty drive any more but calls
> into bdrv_open(). This in turn will fail with no driver and filename
> specified.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 100
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
> blockdev.c | 52 ++++++++++----------------------
> 2 files changed, 111 insertions(+), 41 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v3 08/21] block: Keep "driver" in bs->options, (continued)
- [Qemu-block] [PATCH v3 08/21] block: Keep "driver" in bs->options, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 11/21] block: Add infrastructure for option inheritance, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 13/21] block: Introduce bs->explicit_options, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 12/21] block: Split out parse_json_protocol(), Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 14/21] blockdev: Set 'format' indicates non-empty drive, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 15/21] qemu-iotests: Remove cache mode test without medium, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 16/21] block: reopen: Extract QemuOpts for generic block layer options, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 18/21] blkdebug: Enable reopen, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 17/21] block: Move cache options into options QDict, Kevin Wolf, 2015/12/04
- Re: [Qemu-block] [PATCH v3 17/21] block: Move cache options into options QDict,
Max Reitz <=
- [Qemu-block] [PATCH v3 19/21] qemu-iotests: Try setting cache mode for children, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 21/21] qemu-iotests: Test reopen with node-name/driver options, Kevin Wolf, 2015/12/04
- [Qemu-block] [PATCH v3 20/21] qemu-iotests: Test cache mode option inheritance, Kevin Wolf, 2015/12/04
- Re: [Qemu-block] [PATCH v3 00/21] block: Cache mode for children etc., Kevin Wolf, 2015/12/07