[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 09/10] qcow2: Make image inaccessible after fail
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH 09/10] qcow2: Make image inaccessible after failed qcow2_invalidate_cache() |
Date: |
Tue, 22 Dec 2015 14:24:11 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 12/22/2015 09:46 AM, Kevin Wolf wrote:
> If qcow2_invalidate_cache() fails, we are in a state where qcow2_close()
> has already been completed, but the image hasn't been reopened yet.
> Calling into any qcow2 function for an image in this state will cause
> crashes.
>
> The real solution would be to get rid of the close/open pair and instead
> do an atomic reset of the involved data structures, but this isn't
> trivial, so let's just make the image inaccessible for now.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/qcow2.c | 3 +++
> 1 file changed, 3 insertions(+)
Band-aids are better than nothing.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 07/10] qcow2: Implement .bdrv_inactivate, (continued)
- [Qemu-block] [PATCH 07/10] qcow2: Implement .bdrv_inactivate, Kevin Wolf, 2015/12/22
- [Qemu-block] [PATCH 08/10] qcow2: Fix BDRV_O_INCOMING handling in qcow2_invalidate_cache(), Kevin Wolf, 2015/12/22
- [Qemu-block] [PATCH 06/10] qemu-img: Prepare for locked images, Kevin Wolf, 2015/12/22
- [Qemu-block] [PATCH 09/10] qcow2: Make image inaccessible after failed qcow2_invalidate_cache(), Kevin Wolf, 2015/12/22
- Re: [Qemu-block] [PATCH 09/10] qcow2: Make image inaccessible after failed qcow2_invalidate_cache(),
Eric Blake <=
- [Qemu-block] [PATCH 10/10] qcow2: Add image locking, Kevin Wolf, 2015/12/22
- Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] qcow2: Implement image locking, Fam Zheng, 2015/12/22
- Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] qcow2: Implement image locking, Daniel P. Berrange, 2015/12/23