[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 0/5] qmp: Add blockdev-mirror
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v4 0/5] qmp: Add blockdev-mirror |
Date: |
Wed, 6 Jan 2016 19:03:55 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 24.12.2015 05:45, Fam Zheng wrote:
> v4: 02: Add Max's rev-by.
> 04: buf_size -> buf-size.
> Add Markus' Ack-by.
> 05: 'node1' -> qmp_target.
> Fix double quotes.
> Add Max's Rev-by.
>
> v3: Rebase to master.
>
> v2: 01: Move bdrv_op_block_all down. [Max]
> 02, 04: Add Max's rev-by.
> 03: Check has_mode and fix "return;". [Max]
> 05: Check target->blk.
> Drop superfluous whitespace. [Max]
> 06: Drop superfluous whitespace hunk and add Max's rev-by. [Max]
>
> This is the counterpart of blockdev-backup. The biggest value of this command
> is to allow full flexibility on target image open options, via blockdev-add.
> For example this could help solve the target provisioning issue in:
>
> http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg02139.html
>
> Fam Zheng (5):
> block: Rename BLOCK_OP_TYPE_MIRROR to BLOCK_OP_TYPE_MIRROR_SOURCE
> block: Extract blockdev part of qmp_drive_mirror
> block: Add check on mirror target
> qmp: Add blockdev-mirror command
> iotests: Add test cases for blockdev-mirror
>
> blockdev.c | 179
> ++++++++++++++++++++++++++++++----------
> hw/block/dataplane/virtio-blk.c | 2 +-
> include/block/block.h | 3 +-
> qapi/block-core.json | 48 +++++++++++
> qmp-commands.hx | 50 ++++++++++-
> tests/qemu-iotests/041 | 100 ++++++++++++++++------
> tests/qemu-iotests/041.out | 4 +-
> 7 files changed, 316 insertions(+), 70 deletions(-)
Thanks, applied to my block tree:
https://github.com/XanClic/qemu/commits/block
Max
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-block] [PATCH v4 0/5] qmp: Add blockdev-mirror,
Max Reitz <=