[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 02/13] typedefs: Add BdrvDirtyBitma
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 02/13] typedefs: Add BdrvDirtyBitmap and HBitmapIter |
Date: |
Fri, 8 Jan 2016 10:13:57 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, 01/05 17:14, John Snow wrote:
>
>
> On 01/04/2016 05:27 AM, Fam Zheng wrote:
> > Following patches to refactor and move block dirty bitmap code could use
> > this.
> >
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> > include/qemu/typedefs.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
> > index 78fe6e8..e83934e 100644
> > --- a/include/qemu/typedefs.h
> > +++ b/include/qemu/typedefs.h
> > @@ -10,6 +10,7 @@ typedef struct AddressSpace AddressSpace;
> > typedef struct AioContext AioContext;
> > typedef struct AllwinnerAHCIState AllwinnerAHCIState;
> > typedef struct AudioState AudioState;
> > +typedef struct BdrvDirtyBitmap BdrvDirtyBitmap;
> > typedef struct BlockBackend BlockBackend;
> > typedef struct BlockBackendRootState BlockBackendRootState;
> > typedef struct BlockDriverState BlockDriverState;
> > @@ -28,6 +29,7 @@ typedef struct EventNotifier EventNotifier;
> > typedef struct FWCfgIoState FWCfgIoState;
> > typedef struct FWCfgMemState FWCfgMemState;
> > typedef struct FWCfgState FWCfgState;
> > +typedef struct HBitmapIter HBitmapIter;
> > typedef struct HCIInfo HCIInfo;
> > typedef struct I2CBus I2CBus;
> > typedef struct I2SCodec I2SCodec;
> >
>
> Should the existing typedefs be removed?
>
> >> include/block/block.h:typedef struct BdrvDirtyBitmap BdrvDirtyBitmap;
> >> include/block/block.h:struct HBitmapIter;
> >> include/qemu/hbitmap.h:typedef struct HBitmapIter HBitmapIter;
Yes! Will do.
- [Qemu-block] [PATCH 00/13] Dirty bitmap changes for migration/persistence work, Fam Zheng, 2016/01/04
- [Qemu-block] [PATCH 01/13] backup: Use Bitmap to replace "s->bitmap", Fam Zheng, 2016/01/04
- [Qemu-block] [PATCH 02/13] typedefs: Add BdrvDirtyBitmap and HBitmapIter, Fam Zheng, 2016/01/04
- [Qemu-block] [PATCH 04/13] block: Remove unused typedef of BlockDriverDirtyHandler, Fam Zheng, 2016/01/04
- [Qemu-block] [PATCH 03/13] block: Move block dirty bitmap code to separate files, Fam Zheng, 2016/01/04
- [Qemu-block] [PATCH 05/13] block: Hide HBitmap in block dirty bitmap interface, Fam Zheng, 2016/01/04
- [Qemu-block] [PATCH 06/13] HBitmap: Introduce "meta" bitmap to track bit changes, Fam Zheng, 2016/01/04