[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] ide: ahci: reset ncq object to unu
P J P
Re: [Qemu-block] [Qemu-devel] [PATCH] ide: ahci: reset ncq object to unused on error
Sat, 9 Jan 2016 00:46:57 +0530 (IST)
+-- On Fri, 8 Jan 2016, John Snow wrote --+
| In both of these error pathways, AIOCB is actually never assigned to
| begin with.
True, it's mentioned in the commit message.
| So it's not necessarily a use-after-free.
| I think it should be safe to put ncq_tfs->used = 0 directly inside of
| ncq_err, and that way we won't have any other error pathways omitting
| this in the future.
Okay, I'll send an updated patch.
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F