[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH 4/5] block/backup: Add subclassed n

From: John Snow
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH 4/5] block/backup: Add subclassed notifier
Date: Tue, 12 Jan 2016 12:57:04 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 01/12/2016 03:46 AM, Paolo Bonzini wrote:
> On 12/01/2016 01:36, John Snow wrote:
>> Instead of relying on peeking at bs->job, we want to explicitly get
>> a reference to the job that was involved in this notifier callback.
>> Extend the Notifier to include a job pointer, and include a reference
>> to the job registering the callback. This cuts out a few more cases
>> where we have to rely on bs->job.
>> Signed-off-by: John Snow <address@hidden>
> Why don't you just put the NotifierWithReturn inside the BackupBlockJob
> struct, and use container_of to get from NWR to BackupBlockJob?
> Paolo

That's another way (including the notifier within the job vs. including
the job within the notifier.) This one simply occurred to me first. Any
strong benefit to that method, or just a matter of style?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]