[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 1/2] blockdev: Error out on negative throttli

From: Alberto Garcia
Subject: Re: [Qemu-block] [PATCH v2 1/2] blockdev: Error out on negative throttling option values
Date: Wed, 13 Jan 2016 11:17:23 +0100
User-agent: Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu)

On Wed 13 Jan 2016 01:52:29 AM CET, Fam Zheng wrote:

> The implicit casting from unsigned int to double changes negative values
> into large positive numbers and accepts them.  We should instead print
> an error.
> Check the number range so this case is catched and reported.

I still don't know why qemu_opt_get_number() convert silently negative
numbers into positive ones, shouldn't it just fail with an "invalid
parameter" error?

> +#define THROTTLE_VALUE_MAX 1000000000000000L

This is larger than LONG_MAX in 32-bit systems, I don't know if you need
to use LL instead.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]