[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH 3/4] Revert "hw/block/fdc: Implemen

From: Eric Blake
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH 3/4] Revert "hw/block/fdc: Implement tray status"
Date: Fri, 15 Jan 2016 10:11:00 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0

On 01/12/2016 08:47 AM, Max Reitz wrote:
> This reverts the changes commit
> 2e1280e8ff95b3145bc6262accc9d447718e5318 applied to hw/block/fdc.c.

Might read better as s/changes commit/changes that commit/

> That commit changed tests/fdc-test.c, too, because after it, one less
> TRAY_MOVED event would be emitted when executing 'change' on an empty
> drive. However, now, no TRAY_MOVED events will be emitted at all, and
> the tray_open status returned by query-block will always be false,
> necessitating (different) changes to tests/fdc-test.c and iotest 118,
> which is why this patch is not a pure revert of said commit.
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  hw/block/fdc.c         |  20 ++-------
>  tests/fdc-test.c       |   2 -
>  tests/qemu-iotests/118 | 117 
> +++++++++++++++----------------------------------
>  3 files changed, 40 insertions(+), 99 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]