[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH] qemu-iotests: Reduce racy output in 028

From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH] qemu-iotests: Reduce racy output in 028
Date: Tue, 19 Jan 2016 17:15:04 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Am 18.12.2015 um 22:49 hat John Snow geschrieben:
> On 12/18/2015 03:46 PM, Eric Blake wrote:
> > On 12/11/2015 06:23 PM, John Snow wrote:
> >> On 12/10/2015 10:27 PM, Eric Blake wrote:
> >>> On my machine, './check -qcow2 028' was failing about 80% of the
> >>> time, due to a race in how many times the repeated attempts
> >>> to run 'info block-jobs' could occur before the job was done,
> >>> showing up as a failure of fewer '(qemu) ' prompts than in the
> >>> expected output.  Silence the output during the repetitions, then
> >>> add a final clean command to keep the expected output useful;
> >>> once patched, I was finally able to run the test 20 times in a
> >>> row with no failures.

> It looks sane to me, because you are deleting the insane portion of the
> expected output. The final "info block" command serves as an assertion
> that the loop polled successfully.
> Reviewed-by: John Snow <address@hidden>

Thanks, applied to the block branch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]