[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v5 0/2] block: Reject negative valu

From: Markus Armbruster
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v5 0/2] block: Reject negative values for throttling options
Date: Wed, 20 Jan 2016 08:25:00 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Fam Zheng <address@hidden> writes:

> v5: Add valid value testing in iotests. [Berto]
>     Add details in commit message. [Markus]
>     Use "%lld" in format string. [Markus]
>     Fix ")" -> "]" in error message. [Kevin]
> Now the negative values are silently converted to a huge positive number
> because we are doing implicit casting from uint64_t to double. Fix it and add 
> a
> test case (this was once fixed in 7d81c1413c9 but regressed when the block
> device option parsing code was changed).

Reviewed-by: Markus Armbruster <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]