[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v2] qemu-img: initialize MapEntry o

From: Eric Blake
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v2] qemu-img: initialize MapEntry object
Date: Fri, 5 Feb 2016 12:56:48 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0

On 02/05/2016 11:12 AM, John Snow wrote:
> Commit 16b0d555 introduced an issue where we are not initializing
> has_filename for the 'next' MapEntry object, which leads to interesting
> errors in Valgrind and Clang -fsanitize=undefined both.


errors in both Valgrind and Clang -fsanitize=undefined.

> Zero the stack object at allocation AND make sure the utility to
> populate the fields properly marks has_filename as false if applicable.
> Signed-off-by: John Snow <address@hidden>
> ---
> v2: Initialize with a compound literal as a future-proofing measure.

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]