[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v3 07/14] blockdev: Add list of monitor-owned Bl

From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH v3 07/14] blockdev: Add list of monitor-owned BlockBackends
Date: Wed, 17 Feb 2016 11:53:45 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Am 16.02.2016 um 19:08 hat Max Reitz geschrieben:
> The monitor does hold references to some BlockBackends so it should have

s/does hold/holds/?

> a list of those BBs; blk_backends is a different list, as it contains
> references to all BBs (after a follow-up patch, that is), and that
> should not be changed because we do need such a list.
> monitor_remove_blk() is idempotent so that we can call it in
> blockdev_auto_del() without having to care whether it had been called in
> do_drive_del() before. monitor_add_blk() is idempotent for symmetry
> reasons (monitor_remove_blk() is, so it would be strange for
> monitor_add_blk() not to be).
> Signed-off-by: Max Reitz <address@hidden>

I think hmp_drive_add() needs a monitor_remove_blk() in its error path.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]