[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH] block: Fix -incoming with snapshot=on

From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH] block: Fix -incoming with snapshot=on
Date: Mon, 22 Feb 2016 10:11:20 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Am 19.02.2016 um 17:12 hat Paolo Bonzini geschrieben:
> On 19/02/2016 16:52, Kevin Wolf wrote:
> > The BDRV_O_INACTIVE flag should only be set for images explicitly opened
> > by the user. snapshot=on needs to create a new qcow2 image and write
> > some metadata to it. This is not a problem because it can't come from
> > the source, so there's no reason to mark it as BDRV_O_INACTIVE, even
> > though it is opened while waiting for the migration to complete.
> > 
> > This fixes an assertion failure when -incoming and snapshot=on are
> > combined.
> > 
> > Signed-off-by: Kevin Wolf <address@hidden>
> Does this also fix "migrate -b"?

No, that still fails for me. I think 'migrate -b' needs to clear
BDRV_O_INACTIVE before it starts using the image on the destination. I
wonder how it ever worked without this, it should have thrown all of the
metadata caches away instead of writing them to the image.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]