[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 2/2] hmp: Extend drive_del to delete nodes witho
Re: [Qemu-block] [PATCH 2/2] hmp: Extend drive_del to delete nodes without BB
Thu, 25 Feb 2016 13:51:03 +0100
On Wed, Feb 24, 2016 at 18:54:45 +0100, Max Reitz wrote:
> On 23.02.2016 18:16, Kevin Wolf wrote:
> > Now that we can use drive_add to create new nodes without a BB, we also
> > want to be able to delete such nodes again.
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> > blockdev.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> It's a bit strange to require the user to specify the node name using
> "node-name" for drive_add, but the to use "id" in drive_del; especially
> because x-blockdev-del uses "node-name", too.
Well, since 'x-blockdev-del' is considered unstable yet I can't really
use it in libvirt, thus we discussed using drive_del as a workaround.
It makes partially sense since we'd add the new node with 'drive_add' in
the first place.
Description: Digital signature