[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 2/2] hmp: Extend drive_del to delete nodes witho
Re: [Qemu-block] [PATCH 2/2] hmp: Extend drive_del to delete nodes without BB
Fri, 26 Feb 2016 14:11:47 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0
On 25.02.2016 13:51, Peter Krempa wrote:
> On Wed, Feb 24, 2016 at 18:54:45 +0100, Max Reitz wrote:
>> On 23.02.2016 18:16, Kevin Wolf wrote:
>>> Now that we can use drive_add to create new nodes without a BB, we also
>>> want to be able to delete such nodes again.
>>> Signed-off-by: Kevin Wolf <address@hidden>
>>> blockdev.c | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>> It's a bit strange to require the user to specify the node name using
>> "node-name" for drive_add, but the to use "id" in drive_del; especially
>> because x-blockdev-del uses "node-name", too.
> Well, since 'x-blockdev-del' is considered unstable yet I can't really
> use it in libvirt, thus we discussed using drive_del as a workaround.
> It makes partially sense since we'd add the new node with 'drive_add' in
> the first place.
Yes, you're right. However, my question was solely about the parameter
name (reusing "id" for a node name). As Kevin replied, for HMP the
parameter name doesn't really matter to the user anyway, so reusing the
"id" parameter here is completely fine.
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 1/2] hmp: 'drive_add -n' for creating a node without BB, (continued)