Re: [Qemu-block] block: Dirty bitmaps and COR in bdrv_move_feature_fields()

[Eric Blake]

On 03/02/2016 02:31 AM, Kevin Wolf wrote:

> 
> Seriously, if you need back references from BDS to BB, watch graph
> modifications above the node, automatically creating new names for
> bitmaps while taking a snapshot and similar things, then you're doing
> something wrong. I don't even want to start thinking about persistent
> bitmaps floating towards the top.
> 
> So I think what we need to do is simple: Keep the bitmaps at the node
> for which they were created. For the cases where we must change what a
> bitmap tracks, we can provide a QMP command to move it. If any name
> change or anything like that is involved, it needs to be explicitly
> requested by the management tool and not automatically be done by qemu
> magic.
> 
> Eric, does this look reasonable for libvirt?

Yes, I think it will be manageable to consistently track bitmaps by
node, with the ability to explicitly move them if needed (preferably
during the same transaction doing whatever else to the node graph that
makes it worth moving the bitmap).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature