[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v10 2/3] quorum: implement bdrv_add_child() and

From: Changlong Xie
Subject: Re: [Qemu-block] [PATCH v10 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()
Date: Tue, 8 Mar 2016 09:42:56 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 03/08/2016 12:02 AM, Eric Blake wrote:
On 03/05/2016 11:13 AM, Max Reitz wrote:

+    index = atoi(child->name + 9);

Optional: Assert absence of an error:

Indeed, atoi() is worthless, because it cannot do error detection.

unsigned long index;
char *endptr;

index = strtoul(child->name + 9, &endptr, 10);
assert(index >= 0 && !*endptr);

Still incorrect; you aren't handling errno properly for detecting all
errors.  Even better is to use qemu_strtoul(), which already handles
proper error detection.

Will fix this in next version, thanks for pointing it out.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]