[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v12 1/3] Add new block driver interface to add/d

From: Alberto Garcia
Subject: Re: [Qemu-block] [PATCH v12 1/3] Add new block driver interface to add/delete a BDS's child
Date: Thu, 10 Mar 2016 15:57:36 +0100
User-agent: Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu)

On Thu 10 Mar 2016 03:49:39 AM CET, Changlong Xie wrote:
> From: Wen Congyang <address@hidden>
> In some cases, we want to take a quorum child offline, and take
> another child online.
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> Signed-off-by: Changlong Xie <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>

> +    if (!tmp) {
> +        error_setg(errp, "The node %s does not have child named %s",
> +                   bdrv_get_device_or_node_name(parent_bs),
> +                   bdrv_get_device_or_node_name(child->bs));
> +        return;

I think it should be "does not have a child" or "does not have any

With that corrected,

Reviewed-by: Alberto Garcia <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]