[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v12 2/3] quorum: implement bdrv_add_child() and

From: Changlong Xie
Subject: Re: [Qemu-block] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()
Date: Mon, 14 Mar 2016 14:02:08 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 03/11/2016 08:21 PM, Alberto Garcia wrote:
On Thu 10 Mar 2016 03:49:40 AM CET, Changlong Xie wrote:
@@ -81,6 +82,8 @@ typedef struct BDRVQuorumState {
      bool rewrite_corrupted;/* true if the driver must rewrite-on-read 
                              * block if Quorum is reached.
+    unsigned long *index_bitmap;

Hi Berto

*NOTE*, In the old version, we just used "bs->node_name", but in the lastest one, as Kevin suggested we introduce "child->child_name"(formart as "children.xxx"), this is the key cause why we need this two functions here.

+    int bsize;
+static int get_new_child_index(BDRVQuorumState *s)
+static void remove_child_index(BDRVQuorumState *s, int index)

Sorry if I missed a previous discussion, but why is this necessary?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]