[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 0/8] block: Introduce common read/write function

From: Stefan Hajnoczi
Subject: Re: [Qemu-block] [PATCH 0/8] block: Introduce common read/write function
Date: Thu, 17 Mar 2016 14:35:44 +0000
User-agent: Mutt/1.5.24 (2015-08-30)

On Tue, Mar 08, 2016 at 01:47:45PM +0100, Kevin Wolf wrote:
> BlockBackends support a few different interfaces for reads and writes. Until
> now they used to forward the requests directly to the BDS layer, which
> implemented wrappers around one central common read/write function that
> contained the actual implementation of features provided by the block layer.
> This only works as long as none of the features are actually on the
> BlockBackend level. As it happens, we have features (writethrough cache, I/O
> throttling) that are currently implemented in the BDS, but must move to the 
> BB.
> As a preparation, this series introduces the mapping of the existing APIs to a
> single coroutine based preadv/pwritev function (as we already have on the BDS
> level) to the BB layer. The BDS version of the emulation can't go away just 
> yet
> because there are internal users of them, but the goal is to remove them in 
> the
> long term.
> Depends on Max's "blockdev: Further BlockBackend work".
> Kevin Wolf (8):
>   block: Use BdrvChild in BlockBackend
>   block: Use blk_co_preadv() for blk_read()
>   block: Use blk_co_pwritev() for blk_write()
>   block: Pull up blk_read_unthrottled() implementation
>   block: Use blk_co_pwritev() in blk_write_zeroes()
>   block: Use blk_prw() in blk_pread()/blk_pwrite()
>   block: Use blk_aio_prwv() for aio_read/write/write_zeroes
>   block: Use blk_co_pwritev() in blk_co_write_zeroes()
>  block.c                   |  47 +++--
>  block/block-backend.c     | 485 
> +++++++++++++++++++++++++++++++++-------------
>  block/io.c                |  24 +--
>  include/block/block.h     |   2 -
>  include/block/block_int.h |  12 ++
>  5 files changed, 401 insertions(+), 169 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

This series conflicts with Paolo's "AioContext fine-grained locking,
part 1 of 3, including bdrv_drain rewrite".

We should merge both of them soon to prevent further conflicts.

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]