[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 02/12] block: Make sure throttled B
Re: [Qemu-block] [Qemu-devel] [PATCH 02/12] block: Make sure throttled BDSes always have a BB
Tue, 22 Mar 2016 15:46:10 -0600
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0
On 03/22/2016 09:33 AM, Kevin Wolf wrote:
> It was already true in principle that a throttled BDS always has a BB
> attached, except that the order of operations while attaching or
> detaching a BDS to/from a BB wasn't careful enough.
> This commit breaks graph manipulations while I/O throttling is enabled.
> It would have been possible, but quite cumbersome, to keep things
> working with some temporary hacks, so it's not worth the hassle. We'll
> fix things again in a minute.
Might read slightly better as:
It would have been possible to keep things working with some temporary
hacks, but quite cumbersome, so it's not worth the hassle.
> Signed-off-by: Kevin Wolf <address@hidden>
> +#if 0
> bdrv_io_limits_enable(bs_new, throttle_group_get_name(bs_top));
> + abort();
If it weren't fixed in the same series, then I'd want some text to go
along with the abort. But since it's temporary, this is fine.
Reviewed-by: Eric Blake <address@hidden>
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Description: OpenPGP digital signature
[Qemu-block] [PATCH 04/12] block: throttle-groups: Use BlockBackend pointers internally, Kevin Wolf, 2016/03/22
[Qemu-block] [PATCH 10/12] block: Drain throttling queue with BdrvChild callback, Kevin Wolf, 2016/03/22