[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v5 6/7] block: add generic full disk encryption

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH v5 6/7] block: add generic full disk encryption driver
Date: Wed, 23 Mar 2016 14:44:14 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0

On 03/18/2016 09:19 AM, Kevin Wolf wrote:

>>>> +    ov = opts_visitor_new(opts);
>>>> +
>>>> +    visit_start_struct(opts_get_visitor(ov),
>>>> +                       "luks", NULL, 0, &local_err);
>>> As this refers to "luks" specifically, shouldn't it be inside the switch
>>> below?
>> Or probably better if I just change it to "", since this parameter
>> is not actually used in this context IIRC.
> NULL then? It would be very obvious then if it were used against our
> expectations.

Yes, please.  The QMP input visitor has a bug where passing non-NULL at
the top-level visit can cause weird behavior with parsing an extra {}; I
have patches to fix it, but in the meantime consistently passing NULL
for the top-level visit is safest.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]